-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow empty string as description - take II #1831
Conversation
With this change, the error message will show the merged (template file and assembly infos) metadata, not only the information from the template file.
FYI, this has broken our builds. Probably intentionally, but still! |
I can revert if that makes sense |
Hi - for now I've pinned our build to use 3.9.1, was more just an informational / warning note to others :-) |
I reverted it. and releases 3.9.2 is in progress. @inosik I think we should raise a warning instead. |
Sorry for the inconvenience, @richard-green, but I think this change is needed. Packages with any of @biehlermi and I had a hard time figuring out why NuGet based test adapters didn't work in a project of ours. The reason was a package created with Paket, which broke VSs discovery process. See also themotleyfool/Klondike#158. |
@forki, I would rather let Paket fail, because a warning message is easily overseen in the output of a build script. It also clearly indicates the cause of the failure, instead of an error later in the process, like in themotleyfool/Klondike#158. But I also agree that this is kind of breaking. |
We could still give it a default description generated from the id and On Jul 25, 2016 8:04 PM, "Ilja Nosik" [email protected] wrote:
|
As @inosik mentioned in https://github.com/themotleyfool/Klondike/issues/158, description is an obligatory field. I'm not a friend of soft fixes. They are almost always a pitfall for anyone who does not know about this. |
Seems like I forgot this in #1728.
However, I also changed the error message to show the merged metadata, not only the infos from
paket.template
. I think that was the intent anyways.